Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to recover when Spotlight returns no results by searching /Applications folder #281

Merged

Conversation

manuyavuz
Copy link
Collaborator

This PR improves #268 a little bit more by searching /Applications folder not only if Spotlight is disabled, but also if it returns no results.

I've experienced this on CircleCI while trying to install additional simulators in my builds. In CircleCI, Spotlight was not disabled, but it simply wouldn't return any results.

Also added a simple description to Readme about the workaround.

@manuyavuz manuyavuz force-pushed the deep-search-on-empty-spotlight-result branch from 61ba13a to 662cfc3 Compare May 27, 2018 06:32
Copy link
Member

@KrauseFx KrauseFx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for your contribution @manuyavuz 👍

@manuyavuz
Copy link
Collaborator Author

@KrauseFx thanks for the invitation!

@catflight thanks for your PR too!

Merging.

@manuyavuz manuyavuz closed this May 27, 2018
@manuyavuz
Copy link
Collaborator Author

Wrong button 😅

@manuyavuz manuyavuz reopened this May 27, 2018
@manuyavuz manuyavuz merged commit c4c4dd8 into xcpretty:master May 27, 2018
@manuyavuz manuyavuz deleted the deep-search-on-empty-spotlight-result branch May 27, 2018 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants